Re: [evolution-patches] gtkhtml preedit_changed callback



On 09 Jul 2003 18:55:57 +0200
Radek Doulík <rodo ximian com> wrote:

> thanks for your patch. Your patch is targeting the right direction, but
> has some issues, mostly with gtk_html_im_reset function.
> 
> I have prepared another patch which should handle it better. I am
> attaching it to this mail. Could you test if it works OK for you,
> please?

I have reworked my patch and went a bit lower to use htmltext. It works
better and is little more simple. I also incorporated your im_reset
changes, these seem to work ok.

I was digging in htmltext for pango attributes, but unfortunately there
seem to be none. The widgets in gtk which support gtkimcontext use
PangoLayout. Either this needs to be implemented into htmltext, or a new
object needs to be written that can render the preedit string properly
with pango attributes.

I couln't test your patch with current cvs version because both the
html-editor test program and evolution crashed so I compiled it into the
latest release. The font style changes didn't have any effect on the
preedit text (probably this needs the cvs tree). IMHO this approach is a
dead-end street anyway, because the preedit string should be rendered with
the pango attributes provided. For some languages a simple underline is
enough, but complex ones like Japanese need more than that.

My patch against 3.0.5 is attached. 


Attachment: preedit_string2.patch
Description: Binary data



[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]