Re: [evolution-patches] Request review my patch for bug #46017

[Ettore Perazzoli <ettore ximian com>]

Hi Antonio,

On Wed, 2003-07-09 at 12:51, Antonio Xu wrote:
> Hello,
>          I have maken a patch for bug #46017, my patch can solve the 
> problem of this bug. My patch also can solve the Incorrect behaviour in 
> file pape of  evolution importer.

Thanks for the patch; this definitely makes it behave more sanely.

On the other hand, the behavior when no importable settings are found
could use some improvements.  With your patch it says:

	Please select the information that you would like to import:
	---
	No data can be imported

and you have to hit "Back" or "Cancel".  It's a bit confusing.

The message should probably be more explanatory, e.g.:

	Evolution didn't find any settings that could be 
	imported from other applications.

(Of course, my wording probably sucks.  :-)  Anna?)

Although, this is probably a more complicated patch since you have to
special case that page...

-- Ettore