[evolution-patches] small valgrind patch to e-reflow.c
- From: Chris Toshok <toshok ximian com>
- To: evolution-patches ximian com
- Subject: [evolution-patches] small valgrind patch to e-reflow.c
- Date: Fri, 04 Jul 2003 12:55:39 -0700
need to guard the call to g_object_unref in dispose, fixes an invalid
read.
Index: ChangeLog
===================================================================
RCS file: /cvs/gnome/gal/ChangeLog,v
retrieving revision 1.791
diff -u -r1.791 ChangeLog
--- ChangeLog 1 Jul 2003 13:17:00 -0000 1.791
+++ ChangeLog 4 Jul 2003 19:48:42 -0000
@@ -1,3 +1,8 @@
+2003-07-04 Chris Toshok <toshok ximian com>
+
+ * gal/widgets/e-reflow.c (e_reflow_dispose): make sure we don't
+ unref the sorter more than once.
+
2003-06-30 Dan Winship <danw ximian com>
* gal/widgets/e-reflow.c (e_reflow_dispose): unref the sorter
Index: gal/widgets/e-reflow.c
===================================================================
RCS file: /cvs/gnome/gal/gal/widgets/e-reflow.c,v
retrieving revision 1.51
diff -u -r1.51 e-reflow.c
--- gal/widgets/e-reflow.c 1 Jul 2003 13:17:01 -0000 1.51
+++ gal/widgets/e-reflow.c 4 Jul 2003 19:48:42 -0000
@@ -773,7 +773,10 @@
g_free(reflow->empty_message);
reflow->empty_message = NULL;
- g_object_unref (reflow->sorter);
+ if (reflow->sorter) {
+ g_object_unref (reflow->sorter);
+ reflow->sorter = NULL;
+ }
G_OBJECT_CLASS(parent_class)->dispose (object);
}
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]