Re: [evolution-patches] Patch to enable cursor and keyboard navigation in mail reader,(v8)

[Radek Doulík <rodo ximian com>]

On Thu, 2003-07-03 at 14:17, yuedong du wrote:
> > > @@ -4679,9 +4682,6 @@
> > >         gint x1, y1, x2, y2, xo, yo;
> > >  
> > >         g_return_val_if_fail (e != NULL, FALSE);
> > > -
> > > -       if (! e->editable)
> > > -               return FALSE;
> > 
> > shouldn't this be rather
> > 
> > if (!e->editable && !e->caret_mode)
> > 	return FALSE;
> > 
> > ?
> 
> The modification here made html_engine_make_cursor_visible() always made
> cursor inside of view, either in editor/reader and caret mode/NOT caret
> mode. Suppose you start evolution with caret mode disabled, and now you
> scroll to somewhere in a mail, then F7 to enable caret mode. The cursor
> maybe outside of user's view. 

the html_engine_make_cursor_visible modifies the view offset and not the
cursor position. so when carret mode is disabled you don't want to make
it scroll view to the place where the invisible(disabled) cursor is.

you may want to call this method after caret mode is enabled to make
cursor visible

Radek