Re: [evolution-patches] Request for review for patch to bug 44485

[Hans Petter Jansson <hpj ximian com>]

On Mon, 2003-06-30 at 23:03, Harry Lu wrote:

>     With Alex Jiang's help, I think we found the reason of this bug. If 
> you set a breakpoint at e_timezone_entry_set_entry(), after you click 
> the earth icon, you will find it is breaked 3 times. ( I am attaching 
> the stack at the end of this mail).  The first is caused by 
> on_button_clicked(). The next 2 are caused by on_entry_changed() which 
> is by gtk_entry_set_text(), one by gtk_entry_delete_text(), the other by 
> gtk_entry_insert_text().  Since display_name is pointing to 
> priv->zone->location, which might be changed or freed between 
> gtk_entry_delete_text() and gtk_entry_insert_text(), so you will end up 
> with garbage chars.
>     So my patch can resolve this bug by g_str_dup the display_name. I 
> attach it here for your review again.

The patch looks correct, and I've applied it to both HEAD and the 1.4
branch. Thanks!

-- 
Hans Petter