Re: [evolution-patches] shell, camel, addressbook, calendar leaks

[Rodrigo Moya <rodrigo ximian com>]

On Tue, 2003-07-01 at 21:15, Dan Winship wrote:
> Committed the camel patch to both branches.
> 
> Still waiting to hear back about the addressbook patch.
> 
> Attaching new shell patch with one more fix and new calendar patch
> addressing the problem Rodrigo pointed out (I think) and also adding
> some more leak fixes.
> 
> 
seems to look ok, although:

> @@ -839,10 +839,15 @@
>                 GNOME_Evolution_Calendar_CalFactory_open (f->data, >
str_uri,                                                       >
only_if_exists,                                                  >
corba_listener, &ev);
> -               if (!BONOBO_EX (&ev))
> -                       break;
> -               else if (BONOBO_USER_EX (&ev, >
ex_GNOME_Evolution_Calendar_CalFactory_UnsupportedMethod))
> +               if (!BONOBO_EX (&ev)) {
> +                       if (supported != NULL)
> +                               *supported = TRUE;
>
here, it should free the exception before returning, right?

cheers