[evolution-patches] Re: seek review for bug 45622, activate popup menu in html editor when shift+F10,

[yuedong du <yuedong du sun com>]

Modified as suggested , and commit in HEAD, a11y-branch, 1.4 branch

Thanks,
York

On Tue, 2003-07-01 at 15:50, Radek Doul铆k wrote:
> On Tue, 2003-07-01 at 01:13, yuedong du wrote:
> > Hi Radek,
> > 
> > 
> > The patch work by handle the 'popup-menu' signal.
> > Shift+F10 is a keybinding of Gtkwidget which bind to 'popup-menu' signal
> > . So as shift+f10  is not overided by gtkhtml, the binding will work and
> > emit a 'popup-menu' signal. And the handler just show the popup menu.
> 
> oh, I see, very nice.
> 
> the patch looks complete then ;-) the signal handler should have return
> value of type gboolean and return TRUE. otherwise it's OK. please also
> add ChangeLog entry explaining your changes. feel free to commit.
> 
> Cheers
> Radek
> 
> PS: evolution-patches sun com doesn't work for me (message cannot be
> delivered). do you mean evolution-patches ximian com? I am also Cc-ing
> Larry.
> 
> > 
> > Regards
> > York
> > 
> > 
> > 
> > On Mon, 2003-06-30 at 23:21, Radek Doul?? wrote:
> > > Hi York,
> > > 
> > > the patch seems to be incomplete? (At least I can't see how it can be
> > > activated by S-F10 key.)
> > > 
> > > Cheers
> > > Radek
> > > 
> > > On Mon, 2003-06-30 at 12:15, yuedong du wrote:
> > > > Hi,
> > > > 
> > > > The patch show the popup menu in mail editor when user type shift+f10.
> > > > This is part of the accessibility project.
> > > > 
> > > > A bug has been filed at #45622.
> > > > 
> > > > 
> > > > 
> > > > Regards
> > > > York
> > > 
> > > 
> 
>