Re: [evolution-patches] Patch for #45775, Calendar related

[Rodrigo Moya <rodrigo ximian com>]

On Wed, 2003-12-24 at 06:57, kidd.wang wrote:
> Rodrigo and JPR,
>        Hi, I'm a new intern at SUN. Bug #45775 has been reassigned to 
> me. Here is a patch for it based on HEAD and it simply adds a calendar 
> keyboard navigation(ctrl+o) to open a dialog for editing the currently 
> selected item in DayView and WeekView. Would you like to spend a little 
> time to review it? Thanks.
>         Merry Christmas:-)
> 
> Index: evolution/calendar/ChangeLog
> ===================================================================
> RCS file: /cvs/gnome/evolution/calendar/ChangeLog,v
> retrieving revision 1.2027
> diff -u -r1.2027 ChangeLog
> --- evolution/calendar/ChangeLog    21 Dec 2003 17:05:14 -0000    1.2027
> +++ evolution/calendar/ChangeLog    23 Dec 2003 09:16:18 -0000
> @@ -1,3 +1,11 @@
> +2003-12-23  Kidd Wang  <kidd wang sun com>
> +
> +    * gui/calendar-commands.c (file_open_event_cb): add a menu item for 
> "open appointment".
> +
> +    * gui/e-cal-view.[ch] (e_calendar_view_open_event): add a 
> signal--"open_event", and bind it to "ctrl+o". When the signal is 
> delivered, a dialog will be opened to edit the selected event.
> +
> +    * gui/e-calendar-table.c (e_calendar_table_on_key_press): press 
> "ctrl-o" to open a dialog.
> +
>
e-calendar-table is the table for tasks, so shouldn't the tasks
component also have that 'Open Task' menu item?

Apart from that it looks ok.

cheers