Re: [evolution-patches] [Fwd: code i have written for gw account setup]

[Rodrigo Moya <rodrigo ximian com>]

On Fri, 2003-12-19 at 18:06, Dan Winship wrote:
> (Rodrigo asked me to comment on the camel stuff...)

> > CamelProviderConfEntry groupwise_conf_entries[] = {
> > 	/* override the labels/defaults of the standard settings */
> > 	{ CAMEL_PROVIDER_CONF_LABEL, "hostname", NULL,
> > 	  /* i18n: the '_' should appear before the same letter it
> > 	     does in the evolution:mail-config.glade "_Host"
> > 	     translation (or not at all) */
> > 	  N_("GroupWise Server:") },
> > 	{ CAMEL_PROVIDER_CONF_LABEL, "username", NULL,
> > 	  /* i18n: the '_' should appear before the same letter it
> > 	     does in the evolution:mail-config.glade "User_name"
> > 	     translation (or not at all) */
> > 	  N_("Groupwise  User_name:") },
> 
> That stuff was copied from Connector, but I don't know if it's really
> necessary here. In particular, for Connector we wanted to override the
> "Username" label to say "Windows username" to make it clear that it was
> asking for the user's Windows username rather than their Exchange
> mailbox name, which might be different. I don't think that applies here.
> So you can probably remove both of those entries. 
> 
ok, removed

> > 	{ CAMEL_PROVIDER_CONF_CHECKSPIN, "ad_limit", NULL,
> > 	  N_("Download limit: %s"), "y:1:500:10000" },
> 
> The "ad" in "ad_limit" stands for "Active Directory". Probably want to
> rename that. :) 
> 
I changed it to "ldap_download_limit"

> > 	{ CAMEL_PROVIDER_CONF_CHECKBOX, "filter", NULL,
> > 	  /* i18n: copy from evolution:camel-imap-provider.c */
> > 	  N_("Apply filters to new messages in Inbox on this server"), "0" },
> 
> The comment doesn't need to be there in the groupwise provider, since it
> will be part of the evolution/ module, so the string will be merged
> together with the matching string from the imap provider automatically
> anyway. 
> 
ok, removed also

> You probably need to copy some of the other options over from the IMAP
> provider. (Eg, "Check for new messages in all folders".) But some of the
> other IMAP options (namespace, etc) wouldn't ever be needed for
> GroupWise. 
> 
ok, copying them.

> > 	groupwise_provider.object_types[CAMEL_PROVIDER_STORE] =
> > 		camel_imap_store_get_type ();
> 
> You probably also want to register a CAMEL_PROVIDER_TRANSPORT provider
> using the SMTP provider too? 
> 
done also

> > 	groupwise_provider.authtypes = camel_sasl_authtype_list (FALSE);
> > 	groupwise_provider.authtypes = g_list_prepend (groupwise_provider.authtypes,
> > 						  &camel_groupwise_password_authtype);
> 
> The GroupWise test server we have set up here doesn't actually support
> any SASL auth types. In that case, we may not want to put the SASL types
> in, since they'll never be usable... 
> 
ok, removed also

> > static guint
> > imap_url_hash (gconstpointer key)
> 
> etc. It would be nice to not have these functions copied+pasted everywhere.
> 
where should they be put?

So, I'm fixing the things you mentioned, and then I'll test the provider
to check everything works ok, and then, I'll send the patch again.

cheers