Re: Re: [evolution-patches] Bounty Hunt patch: Set wallpaper from mailer




Hi David,

Patch looks ok to me (some tiny niggles i could niggle about but they're irrelevent), Jeff?  Do you have commit access, for when the copyright assignment is sorted, otherwise we'll put the patch in for you.

Cheers (and 'welcome to the team'),

Michael

On Wed, 2003-12-10 at 23:47 -0500, David Moore wrote:
> I'd prefer you do something more like:
> 
> CamelContentType *ct;
> 
> if (!filename || !filename[0]) {
>    ct = camel_mime_part_get_content_type(t->data.part.part);
>    g_free (filename);
>    filename = g_strdup_printf (_("untitled_image.%s"), ct->subtype);
> }

Okay, here's a (hopefully final) patch. Sorry I took so long, I've been out of town.

Have you guys gotten my copyright assignment yet?


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]