Re: [evolution-patches] Patch for bug #51924,Mailer related for 1.4 branch

[Not Zed <notzed ximian com>]

On Tue, 2003-12-09 at 20:27, Antonio Xu wrote:
> Hello all,
>
> I have created a patch for bug #51924. In this patch, I add a judgement

The bug should really have a backtrace, it isn't obvious why its crashing at first look.

> to avoid adding null filter into filtered stream, that will solve the 
> crash issue. We should judge whether the filter is a valid pointer 
> before add it into filtered stream. Because we couldn't create the 
> filter on SuSe, if the specific charset was NULL. My patch is apply to 
> evolution 14 branch. Please review it.
There shouldn't be a way for the charset to be invalid.  Is there a charset listed in the composer which isn't available on the system in question?

Anyway the patch is still relevent, as Jeff suggested, just add a {} around both the filter_add and object_unref calls, as you can't pass null to camel_object_unref.