Re: [evolution-patches] Re: patch for bug 49599

[Chris Toshok <toshok ximian com>]

more on this.  Michael just committed the fix to libbonoboui (on HEAD
and both 2.2 and 2.4 branches.)

Chris

On Fri, 2003-12-05 at 09:40, Chris Toshok wrote:
> Does bonoboui still call the verbs associated with keybindings when the
> command has been flagged insensitive?  If it does, there's a bug in
> bonoboui..  If it doesn't, then this shouldn't be necessary.
> 
> Chris
> 
> On Fri, 2003-12-05 at 01:49, leon.zhang wrote:
> > hi, Chris
> > 
> > patch below is for fixing bug 49599.
> > it can skip "DEL" key event when no selection exist in addressbook view.
> > pls, review it.
> > 
> > regards
> > 
> > leon
> > 
> > 
> > 
> > 
> > 
> > 
> > 
> > Index: ChangeLog
> > ===================================================================
> > RCS file: /cvs/gnome/evolution/addressbook/ChangeLog,v
> > retrieving revision 1.1435.2.24
> > diff -u -r1.1435.2.24 ChangeLog
> > --- ChangeLog	1 Dec 2003 17:35:44 -0000	1.1435.2.24
> > +++ ChangeLog	5 Dec 2003 09:44:43 -0000
> > @@ -1,3 +1,10 @@
> > +2003-12-04 Leon Zhang <leon zhang sun com>
> > +
> > +	* /gui/widgets/e-addressbook-view.c:
> > +	(e_addressbook_view_delete_selection): skip DEL key when no
> > +	selection exist in addressbook view.
> > +	Fix bug 49599.
> > +
> >   2003-12-01  Frederic Crozat  <fcrozat mandrakesoft com>
> > 
> >   	* gui/component/e-address-widget.c: (e_address_widget_new_control):
> > Index: gui/widgets/e-addressbook-view.c
> > ===================================================================
> > RCS file: /cvs/gnome/evolution/addressbook/gui/widgets/e-addressbook-view.c,v
> > retrieving revision 1.115.4.1
> > diff -u -r1.115.4.1 e-addressbook-view.c
> > --- gui/widgets/e-addressbook-view.c	17 Jul 2003 16:58:02 -0000	1.115.4.1
> > +++ gui/widgets/e-addressbook-view.c	5 Dec 2003 09:44:46 -0000
> > @@ -1778,12 +1778,14 @@
> >   void
> >   e_addressbook_view_delete_selection(EAddressbookView *view)
> >   {
> > -	CardAndBook card_and_book;
> > +	if (e_addressbook_view_can_delete (view)) {
> > +		CardAndBook card_and_book;
> > 
> > -	memset (&card_and_book, 0, sizeof (card_and_book));
> > -	card_and_book.view = view;
> > +		memset (&card_and_book, 0, sizeof (card_and_book));
> > +		card_and_book.view = view;
> > 
> > -	delete (GTK_WIDGET (view), &card_and_book);
> > +		delete (GTK_WIDGET (view), &card_and_book);
> > +	}
> >   }
> > 
> >   static void
> > 
> _______________________________________________
> Evolution-patches mailing list
> Evolution-patches lists ximian com
> http://lists.ximian.com/mailman/listinfo/evolution-patches