[evolution-patches] Re: [Evolution-hackers] e_cal_get_object_list query

[JP Rosevear <jpr ximian com>]

Almost there:

On Mon, 2003-12-01 at 17:14, William Jon McCann wrote:
> @@ -2649,13 +2655,10 @@
>  	instances = NULL;
>  
>  	for (l = objects; l; l = l->next) {
> -		ECalComponent *comp;
> -
> -		comp = l->data;
> -		e_cal_recur_generate_instances (comp, start, end, add_instance, &instances,
> -					      e_cal_resolve_tzid_cb, ecal,
> -					      priv->default_zone);
> -		g_object_unref (G_OBJECT (comp));
> +		e_cal_recur_generate_instances (l->data, start, end, add_instance, &instances,
> +						e_cal_resolve_tzid_cb, ecal,
> +						priv->default_zone);
> +		g_object_unref (G_OBJECT (l->data));
>  	}
>  
>  	g_list_free (objects);

Generally, you don't want to change things you don't have to, so
changing the cast stuff isn't we really desired.  Also if you could fix
the G_OBJECT cast in the unref that would be cool (its not necessary,
removing it should not cause warnings or anything).

-JP
-- 
JP Rosevear <jpr ximian com>
Ximian, Inc.