[evolution-patches] Addressbook 1.4 : fix function name



Hi,

a Mdk contributor (Chris Gleba <chris soma 978 org>) found a problem in
gui/component/e-address-widget.c where
e_address_widget_factory_new_control was not renamed to
e_address_widget_new_control, which it should have, based on Ettore
entry in Changelog.pre-1.4 :
       * gui/component/e-address-widget.c
        (e_address_widget_factory_init): Removed.
        (e_address_widget_new_control): Renamed from
        e_address_widget_factory_new_control(), made public.
        (e_address_widget_factory): Removed.

It is causing some error (see bug
http://qa.mandrakesoft.com/show_bug.cgi?id=6463 ) and I have a patch to
fix this (1.4 only, HEAD is not affected).

Can I commit ?
-- 
Frederic Crozat <fcrozat mandrakesoft com>
Mandrakesoft
? evolution-1.4.5-addressbookrename.patch
? backend/ebook/tests/ebook/Makefile
? backend/ebook/tests/ebook/Makefile.in
? util/Makefile
? util/Makefile.in
Index: ChangeLog
===================================================================
RCS file: /cvs/gnome/evolution/addressbook/ChangeLog,v
retrieving revision 1.1435.2.23
diff -u -r1.1435.2.23 ChangeLog
--- ChangeLog	10 Nov 2003 02:41:05 -0000	1.1435.2.23
+++ ChangeLog	1 Dec 2003 11:10:23 -0000
@@ -1,3 +1,9 @@
+2003-12-01  Frederic Crozat  <fcrozat mandrakesoft com>
+
+	* gui/component/e-address-widget.c: (e_address_widget_new_control):
+	Really rename e_address_widget_factory_new_control into
+	e_address_widget_new_control (Mdk bug #6463, found by Chris Gleba)
+
 2003-11-06 Leon Zhang <leon zhang sun com>
 
 	* gui/widgets/e-minicard.c: (e_minicard_event):
Index: gui/component/e-address-widget.c
===================================================================
RCS file: /cvs/gnome/evolution/addressbook/gui/component/Attic/e-address-widget.c,v
retrieving revision 1.14.8.1
diff -u -r1.14.8.1 e-address-widget.c
--- gui/component/e-address-widget.c	14 Aug 2003 07:26:06 -0000	1.14.8.1
+++ gui/component/e-address-widget.c	1 Dec 2003 11:10:23 -0000
@@ -533,7 +533,7 @@
 }
 
 BonoboControl *
-e_address_widget_factory_new_control (void)
+e_address_widget_new_control (void)
 {
 	BonoboControl *control;
 	BonoboPropertyBag *bag;


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]