Re: [evolution-patches] Patch for bug/bounty #127536

[ERDI Gergo <cactus cactus rulez org>]

On Sun, 30 Nov 2003, Rodney Dawes wrote:

> +       /*
> +       uic = window->priv->uic = bonobo_ui_component_new_default ();
> +       bonobo_ui_component_set_container (
> +               uic, BONOBO_OBJREF (bonobo_window_get_ui_container
> (window)),
> +               NULL);
> +       */
> 
> I don't understand what the point of adding code that is commented out
> anyway, is. Is there some point to this? Why is it commented out?

obviously this is just left in, I'll remove it from the final version.

> +2003-11-24  ERDI Gergo  <cactus cactus rulez org>
> +
> +       * e-shell-window.c (setup_offline_toggle): Merge the
> +       online/offline toggle into the status bar as a proper Bonobo
> +       Control
> 
> Your patch does a lot more than just this, and this entry is seemingly
> unrelated to the bounty at hand. It should probably mention the bug #,
> bounty, and what the goal of your patch is, along with the side affect
> of making the online/offline toggle a bonobo control.

OK so here's the explanation.
#127536 is about displaying stuff (specifically, URI's) in the status bar
of both the main shell and stand-alone mail windows. When implementing
this, I realized that the E main shell uses its own hacks to display the
menu/toolbar hints, instead of using the statusbar provided by
BonoboWindow. This has the negative side-effect that flashing messages in
the status bar via the BonoboUI system creates a new status bar and thus
clutters up the whole GUI.
Ths proper solution is to make the main shell use the
BOnoboWindow-provided status bar. However, that requires custom statusbar
widgets to be embedded via BonoboUI as well, which requires BOnoboControl
wrappers around the widgets.

I can change the ChangeLog entry to contain a shorter version of this
rationale if you'd like.

I'd like to hear about the actual content of the patch as well...

Bye,
	Gergo

-- 
   .--= ULLA! =---------------------.   `We are not here to give users what
   \     http://cactus.rulez.org     \   they want'  -- RMS, at GUADEC 2001
    `---= cactus cactus rulez org =---'
Esszé: írd le a világegyetemet legfeljebb 500 szóban. Adj meg két példát is!