Re: [evolution-patches] seek review for bug #47863 (calendar)

[jack <jack jia sun com>]

Sorry, I missed the patch in the previous mail.

> Hi JP & rodrigo:
>
> Please the review the patch for bug #47863 , and give me your suggestion.
>
> when deleting the task subfolder. evolution-alarm-notify will call 
> AlarmNotify_removeCalendar. In this function, it call
> g_hash_table_lookup_extended to search the uri, if it can not find the 
> uri in the hash table, it will return a arbitrariy value (lc and
> orig_uri), it will cause crash, always on SuSE, and sometimes on Redhat.
>
> So, I suggest to set the initial value of lc_ptr and orig_str_ptr to 
> NULL, the method can avoid crash.
>
> Thanks
> jack
>
> _______________________________________________
> Evolution-patches mailing list
> Evolution-patches lists ximian com
> http://lists.ximian.com/mailman/listinfo/evolution-patches


Index: ChangeLog
===================================================================
RCS file: /cvs/gnome/evolution/calendar/ChangeLog,v
retrieving revision 1.1802.2.29
diff -u -r1.1802.2.29 ChangeLog
--- ChangeLog	22 Aug 2003 15:23:34 -0000	1.1802.2.29
+++ ChangeLog	26 Aug 2003 08:45:29 -0000
@@ -1,3 +1,10 @@
+2003-08-26  Jack Jia  <jack jia sun com>
+
+	** Fixes #47863.
+
+	* gui/alarm-notify/alarm-notify.c (AlarmNotify_removeCalendar): set
+	the initial value of lc_ptr and orig_str_ptr to NULL to avoid crash.
+
 2003-08-21  Frederic Crozat  <fcrozat mandrakesoft com>
 
 	* gui/alarm-notify/notify-main.c: (main):
Index: gui/alarm-notify/alarm-notify.c
===================================================================
RCS file: /cvs/gnome/evolution/calendar/gui/alarm-notify/alarm-notify.c,v
retrieving revision 1.20
diff -u -r1.20 alarm-notify.c
--- gui/alarm-notify/alarm-notify.c	30 Apr 2003 11:12:28 -0000	1.20
+++ gui/alarm-notify/alarm-notify.c	26 Aug 2003 08:45:31 -0000
@@ -297,6 +297,9 @@
 	gpointer lc_ptr, orig_str_ptr;
 	gboolean found;
 
+	lc_ptr = NULL;
+	orig_str_ptr = NULL;
+
 	an = ALARM_NOTIFY (bonobo_object_from_servant (servant));
 	priv = an->priv;