Re: [evolution-patches] Patch for #47874, GAL and calendar related



On Mon, 2003-08-25 at 12:03, Rui Miguel Seabra wrote:

> So what is being added is an irrelevant (and dangerous) test.

This is not an irrelevant test.  If xmlParseFile quietly returned NULL,
there would be no problem.  The problem lies in the fact that it bitches
to stdout that the file doesn't exist.  Therefore, if you don't want
your app to make noise, you have to test if the file exists before you
call xmlParseFile.

I'm not sure what you think is dangerous about adding this check.  The
result of a file disappearing between the file_test and the xmlParseFile
call is the current behavior of a nag to stdout.

-- 
Mike Kestner <mkestner ximian com>




[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]