Re: [evolution-patches] Fix mailto: handling of arbitrary headers.

[Jeffrey Stedfast <fejj ximian com>]

committed to HEAD with slight modifications.

Jeff

On Tue, 2003-08-19 at 10:57, David Woodhouse wrote:
> Against -HEAD.
> 
> Index: composer/ChangeLog
> ===================================================================
> RCS file: /cvs/gnome/evolution/composer/ChangeLog,v
> retrieving revision 1.564
> diff -u -p -r1.564 ChangeLog
> --- composer/ChangeLog	13 Aug 2003 17:24:23 -0000	1.564
> +++ composer/ChangeLog	19 Aug 2003 14:56:00 -0000
> @@ -1,3 +1,8 @@
> +2003-08-19  David Woodhouse  <dwmw2 infradead org>
> +
> +	* e-msg-composer.c (handle_mailto): Fix insertion of arbitrary
> +	headers from mailto: links. Don't honour From: and Reply-To:
> +
>  2003-08-13  Lorenzo Gil Sanchez  <lgs sicem biz>
>  
>  	* e-msg-composer-hdrs.c (account_removed_cb): fixed an insulting
> Index: composer/e-msg-composer.c
> ===================================================================
> RCS file: /cvs/gnome/evolution/composer/e-msg-composer.c,v
> retrieving revision 1.407
> diff -u -p -r1.407 e-msg-composer.c
> --- composer/e-msg-composer.c	11 Aug 2003 17:59:54 -0000	1.407
> +++ composer/e-msg-composer.c	19 Aug 2003 14:56:01 -0000
> @@ -3917,9 +3917,14 @@ handle_mailto (EMsgComposer *composer, c
>  					e_msg_composer_attachment_bar_attach (E_MSG_COMPOSER_ATTACHMENT_BAR (composer->attachment_bar),
>  									      content);
>  				}
> +			} else if (!strncasecmp (header, "from", len) ||
> +				   !strncasecmp (header, "reply-to", len)) {
> +				/* FIXME: Warn about nasty mailto: link? */
>  			} else {
>  				/* add an arbitrary header? */
> -				e_msg_composer_add_header (composer, header, content);
> +				char *real_hdr = g_strndup(header, len);
> +				e_msg_composer_add_header (composer, real_hdr, content);
> +				g_free(real_hdr);
>  			}
>  			
>  			g_free (content);
-- 
Jeffrey Stedfast
Evolution Hacker - Ximian, Inc.
fejj ximian com  - www.ximian.com