[Fwd: Re: [evolution-patches] Re: Changes In Bug # 46013]

[Maxx Cao <maxx cao sun com>]

Hi,

Sorry for pushing, but could you please review this patch for me? It's 
quite simple. Thank you!

--
Best Regards
Maxx

--- Begin Message ---

• From: Maxx Cao <maxx cao sun com>
• To: anna ximian com, Ettore Perazzoli <ettore ximian com>
• Cc: evolution-patches <evolution-patches lists ximian com>
• Subject: Re: [evolution-patches] Re: Changes In Bug # 46013
• Date: Mon, 11 Aug 2003 10:23:51 +0800

Thanks a lot for your comments, Anna and Ettore. I made it "T_o" because I assumed that
there's a menu "_Tool" for the composer of evo, just like mozilla and outlook. But it's not
there ... :-[ .

Anyway, thanks for the recommendation of HIG documentation. I'll follow it. Here
attaches the patch for this bug, which is quite simple. Please review. Thank you!

anna ximian com wrote:

Hello Maxx,

Thanks for your work!

Yes, indeed, the accelerator should be "_T". In the future, please refer
to the HIG when assigning access keys; the following link should take you
right to the appropriate section of it --
http://developer.gnome.org/projects/gup/hig/1.0/userinput.html#choosing-access-keys
.

cheers,
Anna


  

On Fri, 2003-08-08 at 01:12, Maxx Cao wrote:
    

Sorry for introducing this annoying patch. :-\ . I think adding
mnemonic for the
buttons is a better choice. Please give opinions. Thanks.
      

Yes.  However, shouldn't the "To:" button be marked as "_To:" instead of
"T_o:"?

Also, this is a string freeze breaking change.

-- Ettore
_______________________________________________
Evolution-patches mailing list
Evolution-patches lists ximian com
http://lists.ximian.com/mailman/listinfo/evolution-patches
    

-- 
Best Regards
Maxx

? .xvpics
? evo-shot.png
Index: ChangeLog
===================================================================
RCS file: /cvs/gnome/evolution/composer/ChangeLog,v
retrieving revision 1.561
diff -u -r1.561 ChangeLog
--- ChangeLog	4 Aug 2003 12:50:11 -0000	1.561
+++ ChangeLog	11 Aug 2003 02:15:44 -0000
@@ -1,3 +1,11 @@
+2003-08-11  Maxx Cao  <maxx cao sun com>
+
+	** For bug #46013
+
+	* e-msg-composer-hdrs.c (header_new_recipient): create buttons
+	with mnemonics
+	(create_headers): add mnemonics for button label
+
 2003-07-31  Antonio Xu  <antonio xu sun com>
 
 	* e-msg-composer.c (drag_data_received): add the drop type of
Index: e-msg-composer-hdrs.c
===================================================================
RCS file: /cvs/gnome/evolution/composer/e-msg-composer-hdrs.c,v
retrieving revision 1.115
diff -u -r1.115 e-msg-composer-hdrs.c
--- e-msg-composer-hdrs.c	18 Jul 2003 13:44:45 -0000	1.115
+++ e-msg-composer-hdrs.c	11 Aug 2003 02:15:44 -0000
@@ -471,7 +471,8 @@
 	
 	priv = hdrs->priv;
 	
-	ret.label = gtk_button_new_with_label (name);
+	ret.label = gtk_button_new_with_mnemonic (name);
+	GTK_OBJECT_UNSET_FLAGS (ret.label, GTK_CAN_FOCUS);
 
 	g_signal_connect_data (ret.label, "clicked",
 			       G_CALLBACK (address_button_clicked_cb),
@@ -532,15 +533,15 @@
 	 * To, CC, and Bcc
 	 */
 	priv->to = header_new_recipient (
-		hdrs, _("To:"),
+		hdrs, _("_To:"),
 		_("Enter the recipients of the message"));
 	
 	priv->cc = header_new_recipient (
-		hdrs, _("Cc:"),
+		hdrs, _("_Cc:"),
 		_("Enter the addresses that will receive a carbon copy of the message"));
 	
 	priv->bcc = header_new_recipient (
-		hdrs, _("Bcc:"),
+		hdrs, _("_Bcc:"),
 		 _("Enter the addresses that will receive a carbon copy of "
 		   "the message without appearing in the recipient list of "
 		   "the message."));

--- End Message ---