Re: [evolution-patches] [Fwd: Re: Resubmit patch for bug 45631, "activate popup menu in mail composer's to/cc"]

[Maxx Cao <maxx cao sun com>]

A minor change must be made for the patch. I used "gdk_event_new" in 
last patch, but it's supported since v2.2, so
to keep consistency, I'll change it back to "g_new0" and "g_free".

Please review, thanks.

Mike Kestner wrote:

> On Sun, 2003-08-10 at 04:13, Maxx Cao wrote:
>  
>
> > Thanks, Mike.
> > I'm sorry for missing those thing last time. Now everything is corrected,
> > please take a review again. Thank you!
> >    
>
> Looks good.  Please commit.   Thanks again for the patch.
>
>  

--
Best Regards
Maxx

Index: ChangeLog
===================================================================
RCS file: /cvs/gnome/gal/ChangeLog,v
retrieving revision 1.802
diff -u -r1.802 ChangeLog
--- ChangeLog	13 Aug 2003 16:40:58 -0000	1.802
+++ ChangeLog	14 Aug 2003 09:09:33 -0000
@@ -1,3 +1,17 @@
+2003-08-14  Maxx Cao  <maxx cao sun com>
+
+	* gal/e-text/e-text.c (e_text_event): change gdk_event_new to g_new0
+	to keep consistency with gtk 2.0
+	(popup_targets_received): change gdk_event_free to g_free accordingly
+
Index: gal/e-text/e-text.c
===================================================================
RCS file: /cvs/gnome/gal/gal/e-text/e-text.c,v
retrieving revision 1.146
diff -u -r1.146 e-text.c
--- gal/e-text/e-text.c	13 Aug 2003 05:58:20 -0000	1.146
+++ gal/e-text/e-text.c	14 Aug 2003 09:09:34 -0000
@@ -2157,7 +2157,8 @@
 
 			/* Simulate a GdkEventButton here, so that we can call e_text_do_popup directly */
 
-			GdkEventButton *button = gdk_event_new (GDK_BUTTON_PRESS);
+			GdkEventButton *button = g_new0 (GdkEventButton, 1);
+			button->type = GDK_BUTTON_PRESS;
 			button->time = event->key.time;
 			button->button = 0;
 			e_text_do_popup (text, button, 0);
@@ -2628,7 +2629,7 @@
       	      gtk_menu_popup (GTK_MENU (popup_menu), NULL, NULL,
 			      popup_menu_placement_cb, (gpointer)text,
 			      button->button, GDK_CURRENT_TIME);
-	      gdk_event_free (button);
+	      g_free (button);
       } else {
 	      gtk_menu_popup (GTK_MENU (popup_menu), NULL, NULL,
 			      NULL, NULL,