Re: [evolution-patches] Patch for #45348

[Jeffrey Stedfast <fejj ximian com>]

This is wrong. The e_*_strftime() functions are supposed to handle this.

Jeff

On Wed, 2003-08-13 at 00:06, Harry Lu wrote:
> NotZed and Jeff,
>     Please review my patch for #45348.  It is the same reason with #47461.
>     The reason is that under solaris, strftime() won't accept "%P" as a 
> valid format. I have to change it to "%p".  The GUI difference is that 
> now "AM/PM" is always in upper case.
>    This patch will need to be checked into 1.4 branch, too.
>    I guess it breaks string freeze.
>       Thanks!
>       Harry
> 
> ______________________________________________________________________
> Index: evolution/mail/ChangeLog
> ===================================================================
> RCS file: /cvs/gnome/evolution/mail/ChangeLog,v
> retrieving revision 1.2761.2.11
> diff -u -r1.2761.2.11 ChangeLog
> --- evolution/mail/ChangeLog	5 Aug 2003 21:38:19 -0000	1.2761.2.11
> +++ evolution/mail/ChangeLog	13 Aug 2003 03:56:59 -0000
> @@ -1,3 +1,10 @@
> +2003-08-13  Harry Lu  <harry lu sun com>
> +
> +	** For #45348
> +
> +	* mail-display.c: (mail_display_render): Change "%P" to "%p" so
> +	that strftime() can work under solaris.
> +
>  2003-08-05  Not Zed  <NotZed Ximian com>
>  
>  	** See bug #47224.  Hook onto clicked rather than button_pressed,
> Index: evolution/mail/mail-display.c
> ===================================================================
> RCS file: /cvs/gnome/evolution/mail/mail-display.c,v
> retrieving revision 1.282.4.4
> diff -u -r1.282.4.4 mail-display.c
> --- evolution/mail/mail-display.c	5 Aug 2003 21:38:20 -0000	1.282.4.4
> +++ evolution/mail/mail-display.c	13 Aug 2003 03:57:00 -0000
> @@ -1872,7 +1872,7 @@
>  			
>  			localtime_r (&target_date, &due);
>  			
> -			e_utf8_strftime_fix_am_pm (due_date, sizeof (due_date), _("by %B %d, %Y, %l:%M %P"), &due);
> +			e_utf8_strftime_fix_am_pm (due_date, sizeof (due_date), _("by %B %d, %Y, %l:%M %p"), &due);
>  		} else {
>  			due_date[0] = '\0';
>  		}
-- 
Jeffrey Stedfast
Evolution Hacker - Ximian, Inc.
fejj ximian com  - www.ximian.com