Re: [evolution-patches] Seeking review for bug #47447

[Anna Marie Dirks <anna ximian com>]

Hi Jeff and Maxx.

Thanks for this patch, Maxx.

I am a bit concerned about this implementation, because if one
accidentally hits the "esc" key while using the druid, then the druid
window disappears, taking all of one's work with it. Since the "esc"
shortcut is not listed anywhere in the druid window or evo menus, the
naive user has really no reason to expect that pressing it could have a
very destructive consequence.

My recommendation is to show a warning message, just as is shown when
one presses "esc" from within the appointment editor, composer, etc,
which alerts the user that all of her data will be lost if she elects to
close the druid at that time.   

Does that make sense to you, Maxx? 

best wishes,
Anna


On Thu, 2003-08-07 at 11:47, Jeffrey Stedfast wrote:
> I'm not sure it is a good idea for a druid to be closed with Escape?
> 
> Anna? opinions?
> 
> assuming this is something desirable, the patch looks ok to me.
> 
> Jeff
> 
> On Thu, 2003-08-07 at 02:27, Yiming Cao wrote:
> > Hi,
> >     This little patch fixes bug #47447 
> > <http://bugzilla.ximian.com/show_bug.cgi?id=47447>, "Add new mail 
> > account window does not close on Esc".  Now the "mail config druid" can be
> > closed when Esc is pressed.
> >     Please review, thanks.
-- 
Anna Marie Dirks <anna ximian com>