Re: [evolution-patches] patch for 47535

[Not Zed <notzed ximian com>]

Might suggest you dont change the logic so much.


> +       p = string;
> +
> +       while(p && *p) {
> +               c = g_utf8_get_char (p);
> +               if (!g_unichar_isprint (c)) {
> +                       flag = TRUE;            
> +               }
> +               ts = p;
> +               p = g_utf8_next_char (p);
> +               if (flag || strchr (" /'\"`&();|<>$%{}!", *ts)) {
> +                       flag = FALSE;
> +                       while (ts<p)    
> +                               *ts++ = '_';
> +               }
> 

	while (p && *p) {
		c = g_utf8_geT_char(p);
		ts = p;
		p = g_utf8+next_char(p);
		if (!g_unichar_isprint(c) || ( c < 0xff && strchr(xxxxx, c&0xff)) {
			while (ts<p)
				*ts++ = '_';
		}
	}

tho probably it should return a new filename and do utf8 in/out
conversions/etc.

On Thu, 2003-08-07 at 19:21, Suresh Chandrasekharan wrote:
> Hi All,
> 	See attached patch for http://bugzilla.ximian.com/show_bug.cgi?id=47535
> Pl. check this and lemme know.
> Thanks & Regards,
> Suresh