Re: [evolution-patches] Re: seek review for bug 47024: implement set/get_caret_offset method of AtkText interface

[Radek Doulík <rodo ximian com>]

On Wed, 2003-08-06 at 11:19, Yuedong Du wrote:
> 
> Radek Doulík wrote:
> 
> > On Wed, 2003-08-06 at 09:38, Yuedong Du wrote: 
> >   
> > > > Also this change doesn't seem to be quite right:
> > > > 
> > > > @@ -160,7 +160,7 @@
> > > >  
> > > >                 parent_obj = get_parent_html (accessible);
> > > >                 if (parent_obj) {
> > > > -                       parent = HTML_OBJECT_ACCESSIBLE (parent_obj);
> > > > +                       parent = html_utils_get_accessible (parent_obj, NULL);
> > > >                 }
> > > >         }
> > > > 
> > > > I think you have to create recursively accessible objects for all
> > > > parents of parent_obj here.
> > > >       
> > > In the loop of html_a11y_get_gtkhtml_parent(), the while loop will go
> > > through all parent of obj. And all the accessible objects will be 
> > > created in each loops.
> > > So I do not need to create all of them here, right?
> > > 
> > >         while (obj) {
> > >                 obj = atk_object_get_parent (obj);
> > >                 if (G_IS_GTK_HTML_A11Y (obj)) {
> > >                         gtkhtml_a11y = GTK_HTML_A11Y (obj);
> > >                         break;
> > >                 }
> > >         }
> > >     
> > html_a11y_get_parent can be called from elsewhere as well. so it has to
> > just return parent's object accessible object or if you change it to
> > create one if it doesn't exist, it has to create it correctly and not
> > with accessible parent unset (NULL second argument in
> > html_utils_get_accessible)
> > 
> > Cheers
> > Radek
> I see, here change to:
>                                                                                 
> @@ -160,7 +160,10 @@
>                                                                                 
>                 parent_obj = get_parent_html (accessible);
>                 if (parent_obj) {
> -                       parent = HTML_OBJECT_ACCESSIBLE (parent_obj);
> +                       parent = html_utils_get_accessible
> (parent_obj, NULL);
> +                       if ((p = html_a11y_get_parent(parent)) !=
> NULL) {
> +                               atk_object_set_parent(parent, p);
> +                       }
>                 }
>         }
> 
> 
> Recursively call html_a11y_get_parent to get parent of the parent
> object. 

okie, looks good.

Cheers
Radek