Re: [evolution-patches] see review for bug #47379

[Rodrigo Moya <rodrigo ximian com>]

On Tue, 2003-08-05 at 10:15, jack wrote:
> JP and Rodrigo!
> 
> Could you review the patch for the bug #47379?
> 
> This patch add some accelerator for the 'File' menu in the new 
> appointment window.
> 
it looks ok to me, although note that this breaks the string freeze for
the 1.4 branch, doesn't it?

cheers
> 
> Thanks
> jack
> 
> ______________________________________________________________________
> 
> Index: ./ui/ChangeLog
> ===================================================================
> RCS file: /cvs/gnome/evolution/ui/ChangeLog,v
> retrieving revision 1.345
> diff -u -r1.345 ChangeLog
> --- ./ui/ChangeLog	17 Jul 2003 10:43:21 -0000	1.345
> +++ ./ui/ChangeLog	5 Aug 2003 07:50:53 -0000
> @@ -1,3 +1,9 @@
> +2003-08-05  Jack Jia  <jack jia sun com>
> +
> +	* evolution-comp-editor.xml: add the accelerator "P" for "Print",
> +	"S" for "Save", "C" for "Save and _Close", "A" for "Save _As...",
> +	"D" for "Delete". Fixes bug #47379.
> + 
>  2003-07-17  Rodrigo Moya <rodrigo ximian com>
>  
>  	* evolution-tasks.xml: s/Expunge/Purge.
> Index: ./ui/evolution-comp-editor.xml
> ===================================================================
> RCS file: /cvs/gnome/evolution/ui/evolution-comp-editor.xml,v
> retrieving revision 1.17
> diff -u -r1.17 evolution-comp-editor.xml
> --- ./ui/evolution-comp-editor.xml	24 Feb 2003 02:19:59 -0000	1.17
> +++ ./ui/evolution-comp-editor.xml	5 Aug 2003 07:50:53 -0000
> @@ -2,7 +2,7 @@
>  
>  <commands>
>  
> -        <cmd name="FilePrint" _label="Print..."
> +        <cmd name="FilePrint" _label="_Print..."
>          _tip="Print this item"
>          stockid="gtk-print"/>
>  
> @@ -10,22 +10,22 @@
>          _tip="Preview the printed item"
>          stockid="gtk-print-preview"/>
>  
> -        <cmd name="FileSave" _label="Save"
> +        <cmd name="FileSave" _label="_Save"
>  	_tip="Save the item and close the dialog box"
>  	accel="*Control*s"
>          stockid="gtk-save"/>
>  
> -        <cmd name="FileSaveAndClose" _label="Save and Close"
> +        <cmd name="FileSaveAndClose" _label="Save and _Close"
>  	_tip="Save the item and close the dialog box"
>          accel="*Control*Return"
>          stockid="gtk-save"/>
>  
> -        <cmd name="FileSaveAs" _label="Save As..."
> +        <cmd name="FileSaveAs" _label="Save _As..."
>  	_tip="Save this item to disk"
>          accel="*Control*Alt*s"
>          stockid="gtk-save-as"/>
>  
> -	<cmd name="FileDelete" _label="Delete"
> +	<cmd name="FileDelete" _label="_Delete"
>  	_tip="Delete this item"
>          stockid="gtk-delete"/>
>