Re: [evolution-patches] gpg --verify patch
- From: Jeffrey Stedfast <fejj ximian com>
- To: evolution-patches ximian com
- Subject: Re: [evolution-patches] gpg --verify patch
- Date: 28 Apr 2003 13:59:17 -0400
this was committed (a while back, but I am going thru e-p@ cleaning out
my "Pending Patches" vfolder)
Jeff
On Tue, 2003-04-15 at 16:41, Jeffrey Stedfast wrote:
> Checking some of Ettore's signatures today, I noticed that the validity
> description was sometimes getting truncated.
>
> Turned out to be a simple logic bug...
>
> pseudo code:
>
> while (!gpg->complete && !gpg->exited) {
> read_from_gpg();
> }
>
> the problem was that gpg would exit before we'd gotten to read all the
> data from the pipes, so we'd exit the loop prematurely.
>
> While I fixed that, I also removed some previous debug printf's I had
> added. Also simplified the process to check if we had flushed the
> diagnostics stream by just using a bit field (had 18 to spare) rather
> than checking of the GByteArray ended with a '\0'
>
> Jeff
--
Jeffrey Stedfast
Evolution Hacker - Ximian, Inc.
fejj ximian com - www.ximian.com
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]