Re: [evolution-patches] patch for HIG-suggested spacing

[Anna Marie Dirks <anna ximian com>]

Hi Rodrigo, 

Thanks for taking a stab at this! The spacing that this patch adds does
indeed go a long way toward making various calendar dialogs HIG
compliant. Good work. 

However, this patch does not completely fix the various bugs that you
referenced below (#41148, #41216, #41235), because it neglects to also
add appropriate padding to the various widgets in the dialogs. (The HIG
specifies both spacing and padding values in its dialog-layout
guidelines.) 

My proposal to you is this: 

1. Commit this stuff, but don't mark bugs #41148, #41216, and #41235 as
fixed. 

2. I'll add the padding, and any additional spacing, to these dialogs to
make them completely HIG compliant. 

3. I'll then make a patch of my work, and will send it to the list. You
can review it to be sure that it doesn't cause any problems. 
 
4. I'll handle the rest of the calendar HIG spacing/padding dialogs,
unless you really really want to -- I think I have a clearer grasp of
how this stuff should work than you guys might, and your time is
probably better spent working on more "serious" bugs. 

sound good? 

Thanks again for your work and patience, Rodrigo. 
best, 
Anna


On Sat, 2003-04-19 at 18:32, Rodrigo Moya wrote:
> This patch fixes some missing places where we are not using the
> HIG-suggested spacing of 6 pixels.
-- 
Anna Marie Dirks <anna ximian com>