Re: [evolution-patches] Fix for #39128



         dnl KDE applnk directory
         dnl ********************
         AC_ARG_WITH(kde-applnk-path, [  --with-kde-applnk-path=PATH    Location of KDE applnk files],
        -            [with_kde_applnk_path="$withval"])
        +            [with_kde_applnk_path="$withval"],
        +           [with_kde_applnk_path="no"])
         if test x"$with_kde_applnk_path" != x"no"; then
                if test -z "$with_kde_applnk_path"; then
        -               with_kde_applnk_path="$prefix/share/applnk"
        +               with_kde_applnk_path="$datadir/applnk"
                fi

If you make it be "no" by default then this fallback doesn't make much
sense anymore.

                if test -d "$with_kde_applnk_path" ; then
                        KDE_APPLNK_DIR="$with_kde_applnk_path"

Probably it would be better to change this too, so if the directory
doesn't exist it errors out instead of silently ignoring the option.

The rest looks good.

-- Ettore

Attachment: signature.asc
Description: This is a digitally signed message part



[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]