[evolution-patches] patch for fixing 41569, 41567, and partial fix for 41038



This patch fixes 41569, 41567 and part of 41038 -- basically, it just
capitalizes some titles that were formerlly lower case. 

However, this patch definitely breaks the string freeze, because it
changes the "Remove Shortcut Group" menuitem/dialog title/dialog text by
substituting "Delete" for "Remove" in those places. I did this because
we currently evidence an inconsistency between the management of folders
and the managment of shortcut groups. (We speak of deleting folders, and
removing shortcut groups.) (This matches the "Delete" button that was
already being used in the dialog.) 

Verily we could fix this by doing the substitution in the other
direction. (Keeping "Remove" for shortcuts, changing the "Delete" to
"Remove" for folders.) 

Or, we could just forget about this part of the patch, not break string
freeze, and live with the inconsistency. 

-Anna




-- 
Anna Marie Dirks <anna ximian com>
Index: ChangeLog
===================================================================
RCS file: /cvs/gnome/evolution/shell/ChangeLog,v
retrieving revision 1.1243
diff -u -u -r1.1243 ChangeLog
--- ChangeLog	17 Apr 2003 20:55:21 -0000	1.1243
+++ ChangeLog	18 Apr 2003 20:15:05 -0000
@@ -1,3 +1,43 @@
+2003-04-18  Anna Marie Dirks  <anna ximian com>
+
+	* glade/evolution-startup-wizard.glade: Added spacing/padding to 
+	first-run dialog. Fixes 41242. 
+
+	* glade/e-shell-folder-creation-dialog.glade: Misc HIG-related tweaks,
+	mostly spacing and padding related. Fixes 41008. 
+
+	* glade/e-folder-list.glade: Added icons and stock buttons to 
+	the autocompletion page of the settings dialog. Fixes 41145.
+
+	* glade/e-shell-config-default-folders.glade: Added appropriate
+	spacing/padding to the default folder pages of the settings dialog. 
+	Partial fix for 41128.
+
+	* glade/e-active-connection-dialog.glade: Fixed padding/spacing/caps
+	of the "Go Offline" dialog. Fixes 41225 and 41227. 
+
+	* e-shell-folder-selection-dialog.c (e_shell_folder_selection_dialog_construct): Added appropriate border width to the folder selection dialog. Fixes 	41022, 41146, 41147, 41010, partially fixes 41025. 
+
+	* e-shell-folder-creation-dialog.c (add_storage_set_view): Added
+	appropriate spacing to the main vbox of the folder creation dialog.
+	Partially fixes 41008.
+	
+	* e-shell-folder-commands.c (delete_dialog): Corrected border 
+	with for Delete Folder dialog. Fixes 41036. 
+	(e_shell_command_copy_folder): Corrected capitalization of the "Copy
+	Folder" window title. Partial fix for 41025. 
+	(e_shell_command_move_folder): Corrected the capitalization of the
+	"Move Folder" dialog. Fixes 41024. 
+
+	* e-shortcuts-view.c
+	(destroy_group_cb): Set the border width of the message dialog 
+	to 6. Also corrected the capitalization for "Delete Shortcut 
+	Dialog". Fixes 41569
+	(show_new_group_dialog): Fixed the title of "Create New Shortcut
+	Group" . Partially fixes 41038.
+	(rename_shortcut_cb): Corrected the label capitalization for 
+	Rename dialog. Fixes 41567.
+
 2003-04-17  Dan Winship  <danw ximian com>
 
 	* e-shell-folder-creation-dialog.c (add_folder_types): If the
Index: e-shortcuts-view.c
===================================================================
RCS file: /cvs/gnome/evolution/shell/e-shortcuts-view.c,v
retrieving revision 1.64
diff -u -u -r1.64 e-shortcuts-view.c
--- e-shortcuts-view.c	6 Feb 2003 07:25:48 -0000	1.64
+++ e-shortcuts-view.c	18 Apr 2003 20:15:06 -0000
@@ -77,7 +77,7 @@
 	char *group_name;
 
 	group_name = e_request_string (GTK_WINDOW (gtk_widget_get_toplevel (GTK_WIDGET (view))),
-				       _("Create new shortcut group"),
+				       _("Create New Shortcut Group"),
 				       _("Group name:"),
 				       NULL);
 
@@ -176,7 +176,7 @@
 						 GTK_DIALOG_DESTROY_WITH_PARENT | GTK_DIALOG_MODAL,
 						 GTK_MESSAGE_QUESTION,
 						 GTK_BUTTONS_NONE,
-						 _("Do you really want to remove group "
+						 _("Do you really want to delete group "
 						   "\"%s\" from the shortcut bar?"),
 						 e_shortcuts_get_group_title (shortcuts, menu_data->group_num));
 
@@ -184,6 +184,13 @@
 				GTK_STOCK_CANCEL, GTK_RESPONSE_CANCEL,
 				GTK_STOCK_DELETE, GTK_RESPONSE_OK,
 				NULL);
+
+	gtk_window_set_title (GTK_WINDOW (message_dialog), "Delete Shortcut Group"); 
+
+	gtk_container_set_border_width (GTK_CONTAINER (message_dialog), 6); 
+	
+	gtk_box_set_spacing (GTK_BOX (GTK_DIALOG (message_dialog)->vbox), 6);
+
 	gtk_dialog_set_default_response (GTK_DIALOG (message_dialog), GTK_RESPONSE_OK);
 
 	response = gtk_dialog_run (GTK_DIALOG (message_dialog));
@@ -263,7 +270,7 @@
 	{ GNOME_APP_UI_ITEM, N_("_New Group..."),
 	  N_("Create a new shortcut group"), create_new_group_cb, NULL,
 	  NULL, 0, 0, 0, 0 },
-	{ GNOME_APP_UI_ITEM, N_("_Remove this Group..."),
+	{ GNOME_APP_UI_ITEM, N_("_Delete this Group..."),
 	  N_("Remove this shortcut group"), destroy_group_cb, NULL,
 	  NULL, 0, 0, 0, 0 },
 	{ GNOME_APP_UI_ITEM, N_("Re_name this Group..."),
@@ -398,7 +405,7 @@
 	shortcut_item = e_shortcuts_get_shortcut (shortcuts, menu_data->group_num, menu_data->item_num);
 
 	new_name = e_request_string (GTK_WINDOW (gtk_widget_get_toplevel (GTK_WIDGET (shortcuts_view))),
-				     _("Rename shortcut"),
+				     _("Rename Shortcut"),
 				     _("Rename selected shortcut to:"),
 				     shortcut_item->name);
 


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]