Re: [evolution-patches] 41468, default folder type when creating exchange public folder



On Thu, 2003-04-17 at 16:42, Dan Winship wrote:
> > If the default_type can no longer be NULL there should be a
> > `default_type != NULL' assertion in
> > e_shell_show_folder_creation_dialog().
> 
> The default type to e_shell_show_folder_creation_dialog can be NULL, it
> just passes "mail" to add_folder_types in that case.

Ah, OK, I missed that.

> > Also, shouldn't it initialize default_item to e.g. -1 and check against
> > -1 instead of zero?
> 
> Yeah, I suppose.

Looks good now.

-- Ettore

Attachment: signature.asc
Description: This is a digitally signed message part



[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]