Re: [evolution-patches] Re: gtkhtml leak fixes

[Larry Ewing <lewing ximian com>]

Yeah, you are definitely right, that code had been moved around too much
I was still missing bits :)  committed with those changes.

--Larry

On Wed, 2003-04-16 at 11:04, Radek Doulík wrote:
> The patch looks OK. Only in gtkhtml-properties.c:53 and gtkhtml.c:752
> 
> 		fixed_desc = pango_font_description_from_string (fixed_name);
> 		if (pango_font_description_get_family (fixed_desc)) {
> 			fixed_size = PANGO_PIXELS (pango_font_description_get_size (fixed_desc));
> 			pango_font_description_free (fixed_desc);
> 		} else {
> 			g_free (fixed_name);
> 			fixed_name = NULL;
> 		}
> 
> I think the fixed_desc should be freed for both branches:
> 
> 		fixed_desc = pango_font_description_from_string (fixed_name);
> 		if (pango_font_description_get_family (fixed_desc)) {
> 			fixed_size = PANGO_PIXELS (pango_font_description_get_size (fixed_desc));
> 		} else {
> 			g_free (fixed_name);
> 			fixed_name = NULL;
> 		}
> 		pango_font_description_free (fixed_desc);
> 
> Sounds good?