Re: [evolution-patches] patch for passing folder_type from shell to importers

[Rodrigo Moya <rodrigo ximian com>]

On Wed, 2003-04-02 at 04:57, Not Zed wrote:
> On Wed, 2003-04-02 at 04:49, Rodrigo Moya wrote:
> > This is needed for the calendar importer which does not import anything
> > right now due to it not knowing what type (calendar or tasks) the folder
> > is.
> 
> Can't it tell from the destination folder type though?
> 
it can contact the shell and determine the folder type from the URI. So,
instead of doing so, I've just added the folder type as a parameter, to
save one extra step, since the folder type is already known in the
importer client.

> > This seems a better approach than contacting the shell from the
> > importers individually.
> 
> I'm not sure, it seems a bit redundant ... 
> 
why?

> But on the other hand, i'd hope the importers can be re-done at some
> point, so might be the easiest approach for now.
> 
yeah, I also think it's not the ideal solution, but seems much better
than having to contact the shell from the importer, which is what we
were doing before to obtain the physical_uri. 

cheer