Re: [Evolution-hackers] [PATCH 3/3] Add some missing includes

[Kjartan Maraas <kmaraas broadpark no>]

tir, 15,.08.2006 kl. 08.50 +0000, skrev Tor Lillqvist:
> må 2006-08-14 klockan 19:58 -0400 skrev Pavel Roskin:
> > From: Pavel Roskin <proski gnu org>
> 
> > --- a/widgets/misc/e-icon-entry.c
> > +++ b/widgets/misc/e-icon-entry.c
> > @@ -39,6 +39,8 @@ #include "e-icon-entry.h"
> >  #include <gtk/gtkentry.h>
> >  #include <gtk/gtkbox.h>
> >  #include <gtk/gtkhbox.h>
> > +#include <gtk/gtkeventbox.h>
> > +#include <gtk/gtkimage.h>
> 
> Isn't the correct thing here to just include <gtk/gtk.h> and not attempt
> to hand-pick individual gtk headers?
> 
That's what the docs tell developers to do at least. We made an effort
to cut down on unneeded includes some time back though because the catch
all includes made compiling slow afair. On the other side including
single headers have caused all kinds of problems for people since not
all headers are meant to be included on their own etc. Making them all
safe to include by themselves is probably a huge amount of work :-)

Cheers
Kjartan