[Evolution-hackers] NewMail notification from folder.changed event

[<karllinuxtest relton ntlworld com>]

Hi all

I am looking into the bug I reported (bugzilla.gnome.org/show_bug.cgi?id=322016) regarding the
new mail notification dbus message - which is sent via
the plugin based on the folder.changed event.

The basic problem is that the folder.changed event is
documented as a generic event on any folder change (not just
newmail), so we get the notification even when no new mail
has actually arrived.

Looking at the code, I see that the folder.changed event is passed an EMEventTargetFolder structure, which is contains a flag EM_EVENT_FOLDER_NEWMAIL (although curiously this flag is inverted in em_event_target_new_folder() - not
sure why).

Therefore the plugin code in new-mail-notify.c could potentially test this flag to decide wether to send the dbus message - this would save having to code a brand new plugin event type.

Any thoughts?

Karl

-----------------------------------------
Email sent from www.ntlworld.com
Virus-checked using McAfee(R) Software 
Visit www.ntlworld.com/security for more information