Re: [Evolution-hackers] startup order for upgrade



On Mon, 2004-01-26 at 11:44 -0500, JP Rosevear wrote:
> On Wed, 2004-01-21 at 01:22, Not Zed wrote:
> > There are a bunch of bugs aggravated/harder to fix because of the
> > migration startup order, e.g. 53084, 52965, and no doubt others.
> > 
> > This patch changes the shell so the upgrade is part of the same code
> > that does the wizard startup, so things can be done in a more logical
> > order.
> > 
> > Anyway, before i do more work (a lot of stuff is still required in the
> > mailer for this change to have any effect), does this break anything
> > else?
> 
> I messed around with this a bit and did it in a different spot because
> when I looked at it, the construct method of the shell seemed like an
> evil place to be throwing up gui's.  The only thing I can think of that

I agree, but its already running the startup wizard there.

The only other alternative is to make it a simple state machine you step
through externally.

> would be a problem here would be the fact that if you cancel the wizard
> now, all the default stuff in .evolution has been created because
> upgradeFromVersion has already been run.

If you cancel the wizard with the current 1.5 code, you already have
stuff in .evolution anyway.





[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]