Re: [Evolution-hackers] some trivial e-d-s patches



On Thu, 2004-01-15 at 16:13 +0000, Mark McLoughlin wrote:
> Hi,
> 
> On Wed, 2004-01-14 at 12:08, Rodrigo Moya wrote:
> > On Tue, 2004-01-13 at 17:40 +0000, Mark McLoughlin wrote:
> > > Hi,
> > > 	These changes were sitting in my tree:
> > > 
> > >   + Remove debugging messages
> > >   + Remove unused backend_died_cb()[1]
> > >   + Fix a leak in ESourceList
> > >   + Don't write out a source <properties> tag if there
> > >     are no sources.
> > > 
> > > 	Okay to commit ?
> > > 
> > > Thanks,
> > > Mark.
> > > 
> > > [1] - Now that I look at it, the signal should be removed completely -
> > > unless this is just an oversight. 
> > > 
> > no, it shouldn't be removed AFAIK. It is the way to know when the
> > backend has died. Before, in 1.4, it was using the EComponentListener
> > object to listen for the backend's death, so I guess we should do the
> > same. Or, JP, is there any reason to not do that now in 2.0?
> 
> 	Okay, but what about the rest of the patch ?
> 
looked ok

cheers




[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]