[Evolution-hackers] Re: seeking review for bug 44862:




On Thu, 2003-06-19 at 22:41, Radek Doul? wrote:
> Hi York,
> 
> thank you very much for this patch. It looks OK to me. I only wonder
> when o is NULL at that place:
> 
> @@ -88,6 +89,8 @@
>  html_utils_get_accessible (HTMLObject *o, AtkObject *parent)
>  {
>         AtkObject *accessible;
> +
> +       if (!o) return NULL;
>  
>         accessible = html_object_get_data (o, ACCESSIBLE_ID);
> 
> Do you know when is it called with NULL object and why? I would rather
> like to see g_return_val_if_fail (o != NULL, NULL); at that place. I
> dunno when it happens though.
> 
Sorry, I have forgot when and where it crash. But it is no harm to do
so. 

Commit this patch in a11y-branch.

> Cheers
> Radek
> 
> 




[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]