Re: [Evolution-hackers] changes undo.
- From: Jeffrey Stedfast <fejj helixcode com>
- To: "Evolution Hackers" <evolution-hackers helixcode com>
- Subject: Re: [Evolution-hackers] changes undo.
- Date: Thu, 29 Jun 2000 21:54:09 EDT
I'm sorry about the indent stuff. It was unintentional and I will try to
avoid format changes in the future.
As far as the CamelException stuff goes, we need to use them there because
otherwise we get errors like:
"Cannot expunge messages: SUCCESS"
This is obviously not a Good Thing (tm). The problem in the code was that
errno was being checked in the calling function when it should not have
been checked (couldn't rely on errno). CamelException being set inside of
the sync code was the only way Dan and I saw that would fix the problem.
Perhaps there is a better way of doing it, but using a CamelException was
the simplest and best way I saw at the time. I have no problem taking out
the use of CamelException, but we need another way of solving the problem.
On Thu, 29 Jun 2000, NotZed wrote:
> Date: Thu, 29 Jun 2000 18:48:09 -0400 (EDT)
> To: evolution-hackers helixcode com
> From: NotZed <notzed helixcode com>
> Subject: [Evolution-hackers] changes undo.
> 2000-06-28 Jeffrey Stedfast <fejj helixcode com>
> * providers/mbox/camel-mbox-summary.c: General cleanup
> (camel_mbox_summary_sync): Fixed a memory leak and added
> CamelException handling.
> No, undo this change. Exceptions dont belong here, and PLEASE DONT
> RUN THE DAMN CODE THROUGH INDENT. You've just stuffed up
> all the diff's.
> evolution-hackers maillist - evolution-hackers helixcode com
] [Thread Prev