Re: proposal for better default sizing



В Сбт, 18/03/2006 в 18:23 +0100, Meik Hellmund пишет:
> I really like the new feature of reusing the last document settings
> for new documents. I am one of those people who hate
> continuous scrolling (I don't move a book up & down when reading it.)
> and this allows me to switch it off once and for ever.
> 
> But why didn't you activate this feature also for the size
> of the evince window?  At least as long as no better algorithm
> for the initial evince window size is implemented, I suggest
> 
> --- ev-window.c.orig    2006-03-07 17:20:38.000000000 +0100
> +++ ev-window.c 2006-03-07 18:06:27.000000000 +0100
> @@ -722,8 +722,8 @@
>         }
> 
>         if (restore_size &&
> -           ev_metadata_manager_get (uri, "window_width", &width, TRUE) &&
> -            ev_metadata_manager_get (uri, "window_height", &height, TRUE)) {
> +           ev_metadata_manager_get (uri, "window_width", &width, FALSE) &&
> +            ev_metadata_manager_get (uri, "window_height", &height, FALSE)) {
>                 gtk_window_resize (GTK_WINDOW (window),
>                                    g_value_get_int (&width),
>                                    g_value_get_int (&height));
> 
> 
> (the patches are w.r.t. version 0.5.1)


Hi Meik

Sorry for a bit late answer and thanks for the patch. Actually I've
tried this behaviour and don't like it much. I am going to try setting
document size not from previous document size but from size/page_size
ratio. I think that is the value that should be constant among user
documents. I am going to commit patch for that soon, but if you have
one, that would be nice. It should not be hard to do that.

> Another point: since I have a big and wide screen I like to use the
> dual mode of evince. But with new documents it may happen that they are
> already in landscape format. So I propose a redefinition of "best fit" mode
> (or the introduction of an "even better fit" mode):
> The patch at the end gives the following behaviour in "best fit" mode:
> Dual mode gets activated if the evince window has "landscape" form and the
> document has "portrait" form and it gets deactivated otherwise.
> 
> If you now look at a document in "portrait" form with "best fit" mode and
> take the mouse and pull your evince window wider or narrower,
> it switches between dual and non-dual mode. That is exactly the behaviour
> I like. Any chances for adopting it?
> 
> Best wishes, Meik
> 
> 

Interesting suggestion, can you file bug about that in gnome bugzilla
and attach your patch there? Although such behaviour will make user
interaction more complicated I think.





[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]