Re: Patch for document types, take 3

[Jonathan Blandford <jrb redhat com>]

David Malcolm <dmalcolm redhat com> writes:

> My patch from a week ago has bit-rotted somewhat.
> 
> Attached is an updated version of the patch and the two new files.
> 
> I fixed things to track changes in CVS, and renamed things so it uses
> ev_document_type_foo/EvDocumentType, rather than
> evince_document_type_foo/EvinceDocumentType (as pointed out by marco on
> IRC).
> 
> OK to commit this?

I'm Okay with the overall approach, but:

> typedef struct _EvDocumentType EvDocumentType;
> 
> const EvDocumentType* ev_document_type_lookup (const char *mime_type);

Why introduce another type here.  Why not just return a GType, and not
bother about ev_document_type_manufacture_instance ().  We can just call
g_object_new () ourselves.  We can index off of it to get the
thumbnail_icon, too.

> EvDocument* ev_document_type_manufacture_instance        (const EvDocumentType *document_type);
> const char* ev_document_type_get_overlaid_thumbnail_icon (const EvDocumentType *document_type);

Thanks,
-Jonathan