Re: Patch for document type handling

[Marco Pesenti Gritti <mpgritti gmail com>]

Hi,

the approach looks good. Something somewhat related we should consider
is to do mime type sniffing instead (or in addition) to extension
matching...

The dvi code is from http://mdvi.sourceforge.net/. The project seem
unmaintained since 2001 so I guess it doesnt make sense to link to the
separate library. I'm not that convinced about the choice  to base the
dvi backend on it, but I havent look at the code.

Marco

On Apr 8, 2005 2:43 AM, David Malcolm <dmalcolm redhat com> wrote:
> I had a go at cleaning up Evince's document type handling code, and it's
> not yet ready to commit, but I wanted to get feedback...
> 
> So attached is a dump of my current diff against CVS: not especially
> clean right now :-)
> 
> I created new files: shell/ev-document-types.[ch]
> 
> This handles the logic for looking up a mimetype and getting the
> corresponding backend (if any); it gets used by shell/ev-window.c to
> handle file opening, and by the Nautilus thumbnailer (not yet tested) -
> so that in theory the thumbnailer should be able to work for any backend
> for which the thumbnailing interface is implemented.
> 
> Since this is shared between evince and the thumbnailer, I created a new
> library: shell/libevbackendfactory.la
> 
> Unfortunately by autotool-fu is weak; I couldn't persuade
> automake/libtool to have a shared library linking to shared libraries
> for the backends.  So right now the patch makes everything statically
> linked (ugh)
> 
> Is this the right direction to go in?
> 
> I also had to turn off the recent document saving; it was locking up
> evince for some reason.
> 
> There are also some warning fixes in the DVI code (where did this code
> come from?  shouldn't we simply link to a separate library?)
> 
> 
> _______________________________________________
> Evince-list mailing list
> Evince-list gnome org
> http://mail.gnome.org/mailman/listinfo/evince-list
> 
> 
> 
>