Re: vararg LOG() macro in 1.4.7


Le vendredi 28 janvier 2005 à 19:06 +0100, Christian Persch a écrit :
> Hi,
> Le mercredi 26 janvier 2005 à 21:50 -0600, Albert Chin a écrit :
> > Epiphany-1.4.7 makes use of a vararg LOG() macro. This is not C89
> > compliant. I'm trying to build 1.4.7 on IRIX. While the SGI c99
> > compiler can grok the LOG() macro, the SGI C++ compiler cannot. So,
> > should I submit a patch that creates LOG#() macros where # >= 2 for
> > the number of macros in the LOG call and substitute accordingly in the
> > source files or should I create a static inline function in
> > lib/ephy-debug.h:
> >   static inline LOG(char *format, ...) {}
> > and then add semicolons to the end of all LOG() calls?
> Is there no other way? Can we redefine LOG() as empty in this case
> perhaps?
> If that's not possible, I think I prefer the static inline function in
> ephy-debug.h. Is there any way as to not require to add ; to all LOG
> calls?

I've added the semicolons now in cvs HEAD, and adapted ephy-debug.h in
the !gnuc-varargs case.

Can you please confirm if that fixes your build problem?


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]