Re: Tab grouping extension.

[Sam Stephenson <sstephenson gmail com>]

On Wed, 25 Aug 2004 23:03:09 +0800, Justin Wake <jwake iinet net au> wrote:
> Well, after missing the tab grouping for a few releases, I finally got
> off my butt and rewrote it, first as a patch for 1.3.3/1.3.5 and then,
> this afternoon, as a proper extension.
> 
> It works much as Epiphany itself did, as at around 1.3.0, with the
> exception that default new tabs (created by Ctrl-T, for example) are
> treated the same way as middle-clicked links in terms of tab
> positioning, primarily because I couldn't see any simple way of letting
> the extension know that this tab needed to be at the end of the list. It
> works, anyhow.
> 
> Thanks to Marco and Christian for the various extensions I pored over to
> understand the extension system (namely, the sample and the tabs menu
> extensions) - it was actually easier than I thought it would be, once I
> figured out GTK+ (it's my first C GTK+ work).
> 
> Minor caveat: a one-line patch against Epiphany itself needs to be made,
> for consistent tab handling. In src/ephy-notebook.c, in the
> ephy_notebook_add_tab routine, epiphany calls the tab_added signal
> handler then (if jump_to is set) jumps to the saved position of the
> newly created tab, not taking into account the possibility that the
> signal handler may (and in this case, does) reorder the tab, thus
> invalidating the position variable. The patch simply recomputes position
> after the signal is emitted, in the event that it's been reordered out
> from under us.
> 
> Included are the patch against epiphany CVS, a patch against epiphany-
> extensions to add the extensions/tab-groups directory for consideration,
> and the source files themselves (which should be placed into epiphany-
> extensions/extensions/tab-groups).
> 
> Enjoy!

Excellent! I can't wait to try it out.

> --
> Justin Wake

Sam