Re: [Epiphany] Re: Security prompt dialogs

[Marco Pesenti Gritti <marco gnome org>]

On Tue, 2003-10-21 at 11:20, Crispin Flowerday wrote:
> > I think there was at least three better ways to solve the issue:
> > 
> > - Convince Owen to support hig dialogs in gtk+ in some way
> > - Hack a new implementation in egg, either using the same api or
> > changing it if necessary. It could have gone in gtk later (3.0 or when
> > Owen would feel comfortable).
> > - Make glade support higgy dialogs
> 
> I don't think that making glade support higgy dialogs would help here, I
> did implement them all as glade dialogs originally, and it was just a
> waste of time as they were so small, using gtk directly was much better.
> 
> We (well tko) wrote the hig-alert class to help creating dialogs with
> proper HIG'y spacing. Almost all dialogs I have seen in applications,
> (and I am afraid to say, even epiphany) don't have the correct spacing.
> By using this class, it makes it easy to create dialogs that are
> correct.
> 
> I agree a better solution would be for Gtk to support hig alerts itself,
> but until then, I make no apologies for using it :)

I agree that glade is not a full solution. There are plenty of better
solution than a custom api for dialogs though.
Even fixup manually is a better solution because when they will be fixed
in gtk it will be trivial to remove the fixups.

> > Anyway I think I have these possibilities to deal with sharing problem.
> > 
> > - Convince galeon people to use gtk at least for mozilla prompts until
> > there is a better solution (or to work on it ;)
> > - Use their hig dialog as private in mozilla/
> > - Modify their code and lose the ability to sync
> 
> I would like to keep the implementations as close possible, If you have
> really strong objections to using the hig-alert class, I will re-work
> them as plain gtk, but it really is quite a nice class :)

I'm certainly not going to use the alert as public api. _Maybe_ I'll be
forced to use it as private to mozilla code, but I'm really unhappy
about the situation.
Being a nice or not isnt really the point. The point is that starting an
helper for something that should be obviously shared between
applications is pointless.

Marco