Re: [Epiphany] Bookmark editor patch

[Christian Persch <chpe stud uni-saarland de>]

Hi,

On Fri, 2003-10-17 at 07:50, Ettore Perazzoli wrote:
> This makes the bookmarks window put the focus in the search entry when
> opened.
> 
> I have found that that's what I want 99% of the time when I am using the
> keyboard (Ctrl-B, then type in what I want), and it shouldn't hurt
> people who use the mouse.

I think the patch is wrong: it grabs focus in _construct(), but the bme
is only ever construced once and lives on forever, so this doesn't work.
You could grab the focus in ephy_bookmarks_editor_parent_set() instead,
which will be called every time the bme is shown from Ctrl-B or menus.
However, I'm not sure at all if we really _want_ to grab focus: if the
entry is non-empty, grabbing focus will select all text and lose the
selection the user was (perhaps) about to paste into the entry. 

Regards,
	Christian