[Epiphany] [Patch] make history window buttons more dialogy

[Dave Bordoley <bordoley pilot msu edu>]

This patch changes the button order to:
[clear][cancel][jump to]

clicking "jump to" closes the dialog. If later we decide we want to add 
context menus (open in new window/tab etc.) than i think we should 
switch to a toplevel window plus menubar (ala the bme). History (at 
least in my experience) is such an unused feature though, that i think 
the dialog as it stands is enough.

ok to commit?

dave
Index: data/glade/epiphany.glade
===================================================================
RCS file: /cvs/gnome/epiphany/data/glade/epiphany.glade,v
retrieving revision 1.5
diff -u -p -r1.5 epiphany.glade
--- data/glade/epiphany.glade	20 Feb 2003 17:22:05 -0000	1.5
+++ data/glade/epiphany.glade	24 Mar 2003 05:43:36 -0000
@@ -26,18 +26,6 @@
 	  <property name="visible">True</property>
 	  <property name="layout_style">GTK_BUTTONBOX_END</property>
 
-		<child>
-		  <widget class="GtkButton" id="history_go_button">
-			  <property name="visible">True</property>
-	      <property name="can_focus">True</property>
-	      <property name="label">gtk-jump-to</property>
-	      <property name="use_stock">True</property>
-	      <property name="relief">GTK_RELIEF_NORMAL</property>
-				<property name="sensitive">False</property>
-	      <signal name="clicked" handler="history_go_button_clicked_cb"/>
-	    </widget>
-	  </child>
-				
 	  <child>
 	    <widget class="GtkButton" id="history_clear_button">
 	      <property name="visible">True</property>
@@ -111,11 +99,24 @@
 	      <property name="can_default">True</property>
 	      <property name="has_default">True</property>
 	      <property name="can_focus">True</property>
-	      <property name="label">gtk-close</property>
+	      <property name="label">gtk-cancel</property>
 	      <property name="use_stock">True</property>
 	      <property name="relief">GTK_RELIEF_NORMAL</property>
-	      <property name="response_id">-7</property>
+	      <property name="response_id">-6</property>
 	      <signal name="clicked" handler="history_ok_button_clicked_cb"/>
+	    </widget>
+	  </child>
+
+	  <child>
+	    <widget class="GtkButton" id="history_go_button">
+	      <property name="visible">True</property>
+	      <property name="sensitive">False</property>
+	      <property name="can_focus">True</property>
+	      <property name="label">gtk-jump-to</property>
+	      <property name="use_stock">True</property>
+	      <property name="relief">GTK_RELIEF_NORMAL</property>
+	      <property name="response_id">0</property>
+	      <signal name="clicked" handler="history_go_button_clicked_cb"/>
 	    </widget>
 	  </child>
 	</widget>



Index: src/history-dialog.c
===================================================================
RCS file: /cvs/gnome/epiphany/src/history-dialog.c,v
retrieving revision 1.5
diff -u -p -r1.5 history-dialog.c
--- src/history-dialog.c	20 Feb 2003 17:22:04 -0000	1.5
+++ src/history-dialog.c	24 Mar 2003 05:43:48 -0000
@@ -509,6 +519,7 @@ history_go_button_clicked_cb (GtkWidget 
 	g_return_if_fail (location != NULL);
 	embed = ephy_embed_dialog_get_embed (EPHY_EMBED_DIALOG (dialog));
 	ephy_embed_load_url (embed, location);
+	g_object_unref (G_OBJECT(dialog));
 }