Patch for #85263, please review



Here is a patch to fix the ultra-stupid #85263.  Uninitialized variables
yada yada C sucks yada yada people are messy yada yada let's use a real
language yada yada.

Is it OK to apply?

  Federico

Index: ChangeLog
===================================================================
RCS file: /cvs/gnome/eog/ChangeLog,v
retrieving revision 1.224
diff -u -r1.224 ChangeLog
--- ChangeLog	17 Jun 2002 23:31:35 -0000	1.224
+++ ChangeLog	20 Jun 2002 20:48:19 -0000
@@ -1,3 +1,9 @@
+2002-06-20  Federico Mena Quintero  <federico ximian com>
+
+	* viewer/eog-image.c (load_image_from_file): Initialize the loader
+	and rsvg_handle variables, otherwise we'll b0rk if we can't open
+	the URI.  Fixes #85263.
+
 2002-06-13  Federico Mena Quintero  <federico ximian com>
 
 	Fixes #85216.
Index: viewer/eog-image.c
===================================================================
RCS file: /cvs/gnome/eog/viewer/eog-image.c,v
retrieving revision 1.27
diff -u -r1.27 eog-image.c
--- viewer/eog-image.c	21 May 2002 01:14:35 -0000	1.27
+++ viewer/eog-image.c	20 Jun 2002 20:48:19 -0000
@@ -288,6 +288,9 @@
 
 	uri = gnome_vfs_uri_new (text_uri);
 
+	loader = NULL;
+	rsvg_handle = NULL;
+
 	/* open uri */
 	result = gnome_vfs_open_uri (&handle, uri, GNOME_VFS_OPEN_READ);
 	if (result != GNOME_VFS_OK)


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]