Re: [Ekiga-devel-list] Ekiga freeze X when dialing: h323:h323.voxgratia.org

[Craig Southeren <craigs postincrement com>]

On Wed, 14 Mar 2007 23:12:25 +0100
Jan Schampera <jan schampera web de> wrote:

> On Wed, 14 Mar 2007 22:43:21 +0100
> yannick <sevmek free fr> wrote:
> 
> > A pop up appears saying "Invalid parameter". Thebonsai tryied it with
> > the same result.
> 
> I can confirm the following behaviour:
> - seems to affect all H323 calls
> - the error popup is from PAssertFunc() which seems to be an overriden
>   PWLib function
> - the error popups are present in a big mass, hence the UI/X
>   nearly-deadlock
> - the Ekiga debug output gives unusual jitter buffer increases
> 
> I attached a ekiga -d 4 output of a call to h323.voxgratia.org and a
> kill -15 some seconds later (from a remote terminal).

Thanks very much for this post.

I've just checked in a fix for this problem into CVS head

    Craig

Update of /cvsroot/openh323/opal/src/h323
In directory sc8-pr-cvs3.sourceforge.net:/tmp/cvs-serv11294

Modified Files:
	h323.cxx 
Log Message:
Fix H.323 problem with payload map and known payload types

Index: h323.cxx
===================================================================
RCS file: /cvsroot/openh323/opal/src/h323/h323.cxx,v
retrieving revision 2.143
retrieving revision 2.144
diff -C2 -d -r2.143 -r2.144
*** h323.cxx	13 Mar 2007 02:17:46 -0000	2.143
--- h323.cxx	14 Mar 2007 22:40:09 -0000	2.144
***************
*** 25,28 ****
--- 25,31 ----
   *
   * $Log$
+  * Revision 2.144  2007/03/14 22:40:09  csoutheren
+  * Fix H.323 problem with payload map and known payload types
+  *
   * Revision 2.143  2007/03/13 02:17:46  csoutheren
   * Remove warnings/errors when compiling with various turned off
***************
*** 2418,2422 ****
                        RTP_DataFrame::PayloadTypes inpt  = rtp->GetMediaStream()->GetMediaFormat().GetPayloadType();
                        RTP_DataFrame::PayloadTypes outpt = rtp->GetDynamicRTPPayloadType();
!                       if (inpt != outpt)
                          rtpPayloadMap.insert(RTP_DataFrame::PayloadMapType::value_type(inpt,outpt));
                      }
--- 2421,2425 ----
                        RTP_DataFrame::PayloadTypes inpt  = rtp->GetMediaStream()->GetMediaFormat().GetPayloadType();
                        RTP_DataFrame::PayloadTypes outpt = rtp->GetDynamicRTPPayloadType();
!                       if ((inpt != outpt) && (outpt != RTP_DataFrame::IllegalPayloadType))
                          rtpPayloadMap.insert(RTP_DataFrame::PayloadMapType::value_type(inpt,outpt));
                      }




-----------------------------------------------------------------------
 Craig Southeren          Post Increment ? VoIP Consulting and Software
 craigs postincrement com au                   www.postincrement.com.au

 Phone:  +61 243654666      ICQ: #86852844
 Fax:    +61 243656905      MSN: craig_southeren hotmail com
 Mobile: +61 417231046      Jabber: craigs jabber org

 "It takes a man to suffer ignorance and smile.
  Be yourself, no matter what they say."   Sting