Re: [Ekiga-devel-list] XV Patch

[Jan Schampera <jan schampera web de>]

On Wed, 7 Feb 2007 22:59:30 +0100 (CET)
Matthias Schneider <ma30002000 yahoo de> wrote:


> Concerning the rework on GDK, please tell me if I can be of any help
> - in my opinion the following functions should be in
> videooutput_gdk.cpp instead of main.cpp (perhaps we can kick out all
> the ifdef HAS_SDL and leave only the if defined HAS_XV || defined
> HAS_SDL):

> void gm_main_window_update_video (GtkWidget *main_window,...
> gboolean gm_mw_init_fullscreen_video_window (gpointer data)
> gboolean gm_mw_poll_fullscreen_video_window (GtkWidget *main_window)
> gboolean gm_mw_destroy_fullscreen_video_window (gpointer data)

> In case with the reworked xv support you are still getting crashes I
> would like to have a look at a backtrace if possible...
> Thanks in advance,
> Matthias


IMHO

They shouldn't really go out IMHO, just the hard working part (the
functionality) should be moved out. Flow control and general control for
the functionality should stay in main.

J.


-- 
I know life sometimes can get tough! and I know life sometimes can be a
drag! But people, we have been given a gift, we have been given a road
And that roads name is... rock and roll!
KISS in "God gave Rock'n'Roll to you"