dogtail-devel [Bug 321431] New: The image comparison function does not work

["dogtail (bugzilla.gnome.org)" <bugzilla-daemon bugzilla gnome org>]

Do not reply to this via email (we are currently unable to handle email
responses and they get discarded).  You can add comments to this bug at
http://bugzilla.gnome.org/show_bug.cgi?id=321431
 dogtail | Framework | Ver: CVS HEAD

           Summary: The image comparison function does not work
           Product: dogtail
           Version: CVS HEAD
          Platform: Other
        OS/Version: Linux
            Status: UNCONFIRMED
          Severity: normal
          Priority: Normal
         Component: Framework
        AssignedTo: dogtail-maint gnome bugs
        ReportedBy: muktha narayan wipro com
         QAContact: dogtail-maint gnome bugs
                CC: all-bugs bugzilla gnome org


Noticed couple of things in the image comparison function.

1. Case when 'metrics' is specified in the image compare:
   The comparison function always returns the result as fail even if the image   
   files are same. This is because for the 'metric didn't fire' case, the check 
   made is that the length of the output of 'compare' should not be 1. But this 
   condition satisfies even when the images are same (since length of the 
   output of 'compare' will be 3). 
   I noticed that for error conditions, the length of the output of 'compare' is 
   '1'. Attaching a patch with this change.

2. Case when no metrics is specified in the image compare:
   Here too, the comparison function returns the result as 'fail' even for image
   files that are same. This is because, the 'compare' command does not return 
   an empty list when the images are same.

------- You are receiving this mail because: -------
You are watching the assignee for the bug.
You are watching the QA contact.